Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to rails 7.0.4 #205

Closed
wants to merge 2 commits into from
Closed

updated to rails 7.0.4 #205

wants to merge 2 commits into from

Conversation

aquillo-au
Copy link
Contributor

Have updated from rails 6 to 7,
Attempted to make as small changes as possible while still having everything work.

@aquillo-au
Copy link
Contributor Author

does that mean i need to fix the rubocop stuff 1st?

Gemfile Outdated
gem 'spring'
gem 'spring-watcher-listen'
gem 'spring', '~> 4.1'
# gem 'spring-watcher-listen'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is no longer required or wanted, then remove rather than comment out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@leesheppard
Copy link
Member

@aquillo-au resolve the build issues and push up again, check the errors locally with Rubocop first to ensure a successful build.

@leesheppard leesheppard linked an issue Apr 20, 2023 that may be closed by this pull request
@leesheppard leesheppard requested a review from pat April 20, 2023 03:16
@aquillo-au aquillo-au closed this by deleting the head repository May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants